Skip to content

Add dtensor mesh conversion test#9474

Merged
jeffhataws merged 1 commit intopytorch:masterfrom
aws-cph:aws-cph_dtensor
Jul 15, 2025
Merged

Add dtensor mesh conversion test#9474
jeffhataws merged 1 commit intopytorch:masterfrom
aws-cph:aws-cph_dtensor

Conversation

@aws-cph
Copy link
Copy Markdown
Contributor

@aws-cph aws-cph commented Jul 11, 2025

Adding tests for DTensor device mesh in regards to #9418.

Copy link
Copy Markdown
Collaborator

@rpsilva-aws rpsilva-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, mostly the same comments for most of the added tests.

Comment thread test/run_tests.sh
Comment thread test/spmd/test_dtensor_convert_mesh.py Outdated
Comment thread test/spmd/test_dtensor_convert_mesh.py Outdated
Comment thread test/spmd/test_dtensor_convert_mesh.py Outdated
@aws-cph aws-cph force-pushed the aws-cph_dtensor branch 3 times, most recently from 00d5918 to 85b3962 Compare July 11, 2025 23:06
@rpsilva-aws rpsilva-aws self-requested a review July 14, 2025 17:00
@rpsilva-aws
Copy link
Copy Markdown
Collaborator

@zhanyong-wan, @qihqi looks like the torchprime test has some issues now. Unrelated CI, no functional changes. PTAL.

@zhanyong-wan
Copy link
Copy Markdown
Collaborator

I'll let a colleague working on distributed API take a look. Talking to him now...

@jeffhataws jeffhataws merged commit 93a5e58 into pytorch:master Jul 15, 2025
40 of 42 checks passed
@jeffhataws
Copy link
Copy Markdown
Collaborator

I'll let a colleague working on distributed API take a look. Talking to him now...

Oops. I merged before I see your comment. This is a new test only addition so it should not affect functionality. Free free to revert if it causes problem.

@aws-cph aws-cph deleted the aws-cph_dtensor branch July 16, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants