Skip to content

Calculate vmem limit dynamically in the quantized matmul kernel.#9470

Merged
vanbasten23 merged 3 commits intomasterfrom
xiowei/calculate_vmem_limit_dynamically
Jul 10, 2025
Merged

Calculate vmem limit dynamically in the quantized matmul kernel.#9470
vanbasten23 merged 3 commits intomasterfrom
xiowei/calculate_vmem_limit_dynamically

Conversation

@vanbasten23
Copy link
Copy Markdown
Collaborator

@vanbasten23 vanbasten23 commented Jul 10, 2025 •
edited
Loading

Test plan:

  • python pytorch/xla/test/test_pallas.py -k test_quantized_matmul_int8
  • pytest pytorch/xla/test/test_quantized_matmul_pallas_kernel.py -s

@vanbasten23 vanbasten23 requested a review from yaochengji July 10, 2025 20:09
@vanbasten23 vanbasten23 marked this pull request as ready for review July 10, 2025 20:09
yaochengji
yaochengji approved these changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

yaochengji
yaochengji reviewed Jul 10, 2025
View reviewed changes
Comment thread torch_xla/experimental/pallas_kernels/quantized_matmul_kernel.py Outdated
@vanbasten23 vanbasten23 mentioned this pull request Jul 10, 2025
Merged
3 tasks
@vanbasten23
Copy link
Copy Markdown
Collaborator Author

vanbasten23 commented Jul 10, 2025

Thanks for the review!

@vanbasten23 vanbasten23 merged commit 83dc9da into master Jul 10, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaochengji yaochengji yaochengji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vanbasten23 @yaochengji