Skip to content

Partially disable tpu-info CLI tests#9463

Merged
bhavya01 merged 2 commits intomasterfrom
cli_test
Jul 9, 2025
Merged

Partially disable tpu-info CLI tests#9463
bhavya01 merged 2 commits intomasterfrom
cli_test

Conversation

@bhavya01
Copy link
Copy Markdown
Collaborator

@bhavya01 bhavya01 commented Jul 9, 2025

cli.print_chip_info() causes a segfault in python 3.12. This is caused by libtpu import.

Commenting out this part of the test till libtpu is fixed. An issue has been created for the libtpu team.

@bhavya01 bhavya01 requested a review from qihqi July 9, 2025 18:48
@bhavya01 bhavya01 enabled auto-merge (squash) July 9, 2025 20:06
@pgmoka pgmoka self-requested a review July 9, 2025 20:20
Copy link
Copy Markdown
Collaborator

@pgmoka pgmoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus two nits.

Comment thread test/tpu/tpu_info/test_cli.py Outdated
Comment thread test/tpu/tpu_info/test_cli.py Outdated
@bhavya01 bhavya01 merged commit 33e8791 into master Jul 9, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants