Make assume_pure able to work with functions that depends on random#9460
Merged
Make assume_pure able to work with functions that depends on random#9460
Conversation
yaoshiang
approved these changes
Jul 9, 2025
Collaborator
yaoshiang
left a comment
There was a problem hiding this comment.
I refreshed my memory on Jax randomness. Indeed, there is no way to avoid passing a seed into a jax function / assume_pure decorated pytorch function.
As discussed, perhaps there's a way to store the state in the decorator's closure but outside the jitted function... I am not sure if that would work.
Functions with randomness are not technically pure, so assuming them to pure has implication that now they lose the randomness. The solution is to lift RNG seed an additional input so that the function's value can depend on that.
a069da2 to
dcebdb3
Compare
Collaborator
Author
Tried that, didnt made it work. Added more test on testing calling random many times inside of assume'd pure block. |
dcebdb3 to
534da4b
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions with randomness are not technically pure, so assuming them to pure has implication that now they lose the randomness.
The solution is to lift RNG seed an additional input so that the function's value can depend on that.