Add support for callable in torchax.interop.JittableModule.functional_call in the first parameter#9451
Merged
qihqi merged 1 commit intopytorch:masterfrom Jul 18, 2025
Conversation
qihqi
approved these changes
Jul 8, 2025
Collaborator
Author
|
@qihqi it's failing on tests that I don't think are connected to this PR, what should I do? |
Collaborator
@zmelumian972 Please rebase to lastest, we fixed it yesterday. |
…od name in `functional_call`
dc21e01 to
f1f6894
Compare
Collaborator
Author
|
Done, sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when working with functional call in JittableModule, it can only work with internal methods inside the module
this PR allows the user to define a callable that will have the model inserted as the first argument (similar to 'self' mechanism in python)
this allows torchax to JIT torch procedures outside the scope of the module