Skip to content

Error Handling: refactor ExecuteComputation and ExecuteReplicated to propagate status.#9445

Merged
ysiraichi merged 3 commits intomasterfrom
ysiraichi/status-for-oom-eager-mode
Jul 29, 2025
Merged

Error Handling: refactor ExecuteComputation and ExecuteReplicated to propagate status.#9445
ysiraichi merged 3 commits intomasterfrom
ysiraichi/status-for-oom-eager-mode

Conversation

@ysiraichi
Copy link
Copy Markdown
Collaborator

@ysiraichi ysiraichi commented Jul 3, 2025 •
edited
Loading

This PR refactors both ComputationClient:::ExecuteComputation and ComputationClient:::ExecuteReplicated functions for propagating error statuses.

Key Changes:

  • Refactors ExecuteComputation and ExecuteReplicated: Now explicitly propagates absl::Status.
  • Replaces Raw .value() Calls: Uses XLA_ASSIGN_OR_RETURN for propagating the status.
  • Updates Call Sites: Leverages GetValueOrThrow for more robust error management.

@ysiraichi

This comment was marked as outdated.

Sign in to view
@ysiraichi ysiraichi force-pushed the ysiraichi/status-for-oom-eager-mode branch 2 times, most recently from bb72d7f to 8f1ba5e Compare July 4, 2025 16:24
@ysiraichi ysiraichi force-pushed the ysiraichi/status-for-oom-errors branch 3 times, most recently from 34abde6 to 103cd0f Compare July 24, 2025 12:40
@ysiraichi ysiraichi force-pushed the ysiraichi/status-for-oom-eager-mode branch from 8f1ba5e to d3e373e Compare July 25, 2025 14:53
@ysiraichi ysiraichi changed the base branch from ysiraichi/status-for-oom-errors to master July 25, 2025 15:11
@ysiraichi ysiraichi marked this pull request as ready for review July 28, 2025 12:46
@ysiraichi ysiraichi force-pushed the ysiraichi/status-for-oom-eager-mode branch from 50f33b9 to 4c3616a Compare July 28, 2025 12:48
zhanyong-wan
zhanyong-wan approved these changes Jul 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zhanyong-wan zhanyong-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ysiraichi added 3 commits July 29, 2025 12:06
@ysiraichi
Make ExecuteComputation and ExecuteReplicated return StatusOr<T>
cc4cdac 
Key changes:
- Updated base `ComputationClient` interface to return `absl::StatusOr<std::vector<DataPtr>>`
- Modified IFRT and PjRt implementations to use proper error propagation
- Replaced raw `.value()` calls with `XLA_ASSIGN_OR_RETURN_WITH_LOCATION` macros
- Updated all call sites to use `GetValueOrThrow` for exception-based error handling
@ysiraichi
Fix compilation.
91e1a72
@ysiraichi
Fix lint issues.
f3f4d78
@ysiraichi ysiraichi force-pushed the ysiraichi/status-for-oom-eager-mode branch from 04bb0d4 to f3f4d78 Compare July 29, 2025 15:07
@ysiraichi ysiraichi merged commit b0ffc49 into master Jul 29, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qihqi qihqi qihqi approved these changes

@zhanyong-wan zhanyong-wan zhanyong-wan approved these changes

@ghpvnist ghpvnist Awaiting requested review from ghpvnist

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ysiraichi @qihqi @zhanyong-wan