Fix status source code location logic.#9440
Merged
Conversation
0427c0a to
d6ba41f
Compare
zhanyong-wan
requested changes
Jul 7, 2025
ghpvnist
reviewed
Jul 7, 2025
zhanyong-wan
requested changes
Jul 8, 2025
zhanyong-wan
approved these changes
Jul 9, 2025
22a420a to
0242960
Compare
zhanyong-wan
approved these changes
Jul 9, 2025
- Refactor status tests - Remove test_status.cpp as its tests are now covered by specialized context tests - Both specialized tests now cover all status utility functions and macros
0242960 to
620e4b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the handling of status source code locations and overhauls related tests. The key changes improve the accuracy of source information and streamline our testing approach:
MacroReturnIfErrorWithNestedErrorthat exemplifies the undesirable behavior.test_status.cpp, copying its tests to the other 2 existing tests:test_status_show_cpp_error_context.cppandtest_status_dont_show_cpp_error_context.cpp. Rationale: the tests should pass with both configurations.Undesired Behavior
Below, we can see the results of the newly added test
MacroReturnIfErrorWithNestedErrorwhenXLA_SHOW_CPP_ERROR_CONTEXT=1: