Deprecate ShapeOfXlaOp in favor of GetShape#9381
Merged
zhanyong-wan merged 1 commit intopytorch:masterfrom Jun 17, 2025
Merged
Conversation
Collaborator
Author
|
@ghpvnist and @ysiraichi , somehow GH doesn't let me request a code review on this PR. Can you review it anyway? Thanks. |
ghpvnist
approved these changes
Jun 17, 2025
Collaborator
ghpvnist
left a comment
There was a problem hiding this comment.
Do you plan to do a follow up to change existing uses of ShapeOfXlaOp?
Collaborator
Author
There are many uses of this. I don't plan to rewrite all of them, as that doesn't have a big ROI. Instead, I may replace some of them as needed for improving a user error message. |
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9096
Deprecate
ShapeOfXlaOp()as:OfXlaOppart of the name is redundant as it's already obvious from the parameter type.Replace it with a new function
GetShape().