scan-based GRU falls back to nn.GRU when bidirectional is true.#8984
Merged
tengyifei merged 2 commits intopytorch:masterfrom Apr 17, 2025
Merged
scan-based GRU falls back to nn.GRU when bidirectional is true.#8984tengyifei merged 2 commits intopytorch:masterfrom
bidirectional is true.#8984tengyifei merged 2 commits intopytorch:masterfrom
Conversation
…al` is set to true.
Collaborator
Author
|
@tengyifei please review |
tengyifei
approved these changes
Apr 16, 2025
Collaborator
tengyifei
left a comment
There was a problem hiding this comment.
Thanks!
Our CI got some troubles yesterday. Once you rebase the PR on the latest master branch, it should be landable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes scan-based GRU implementation to fall back to the standard pytorch GRU when
bidirectionalis true. scan-based GRU will not supportbidirectionalunless there is enough demand. for details: #8860