Conversation
tengyifei
approved these changes
Apr 14, 2025
Member
Author
|
I am still seeing the failure randomly. Actually if we check the error, the error always happens in flash attention sharding during backward: xla/torch_xla/experimental/custom_kernel.py Line 695 in 4eea5e1 |
Member
Author
|
Disable the whole splash attention test for now to unblock other PRs first. Will bring it back once #8971 is resolved. |
Collaborator
|
Ack. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
test_splash_attention_segment_idto unblock others PR. The failure only happens in github CI randomly. I am unable to reproduce it locally. Will bring it back once I figure it out.