Add an option for JittableModule to dedup parameters.#8965
Merged
Conversation
036d540 to
2f8de95
Compare
yaoshiang
requested changes
Apr 11, 2025
Collaborator
yaoshiang
left a comment
There was a problem hiding this comment.
Cool stuff here, nice to see the donate args in action.
dfc4ca3 to
811eeef
Compare
yaoshiang
approved these changes
Apr 13, 2025
Collaborator
yaoshiang
left a comment
There was a problem hiding this comment.
approved, with optional nits and optional comment on design.
713c10b to
af84080
Compare
af84080 to
25e81e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option for JittableModule to dedup parameters.
This is needed when we want to use the
donate_argnumsfeature of jax_jit. Because, if duplicated parameters are passed into the callable with donated argnums, then, it will show an argument is donated twice and error out.