Skip to content

Remove deprecated typing module in ansible flow#8955

Merged
qihqi merged 1 commit intomasterfrom
yifeit/fix-build-xla-3
Apr 10, 2025
Merged

Remove deprecated typing module in ansible flow#8955
qihqi merged 1 commit intomasterfrom
yifeit/fix-build-xla-3

Conversation

@tengyifei
Copy link
Copy Markdown
Collaborator

@tengyifei tengyifei commented Apr 10, 2025

Remove deprecated typing module (it's built into Python now).

@tengyifei
Try to fix nightly build
7dfab55 
Remove deprecated typing module (it's built into Python now).
@tengyifei tengyifei changed the title Try to fix nightly build Remove deprecated typing module in ansible flow Apr 10, 2025
@tengyifei tengyifei marked this pull request as ready for review April 10, 2025 05:48
@zpcore
Copy link
Copy Markdown
Member

zpcore commented Apr 10, 2025

Curious what is the build error you see?

@qihqi qihqi merged commit e77bd2f into master Apr 10, 2025
24 checks passed
@tengyifei
Copy link
Copy Markdown
Collaborator Author

tengyifei commented Apr 10, 2025

Curious what is the build error you see?

The error was

Step #2 - "build_xla_docker_image":   stdout: |-
Step #2 - "build_xla_docker_image":     Building wheel torch-2.8.0
Step #2 - "build_xla_docker_image":     invalid command 'bdist_wheel'

So the PyTorch upstream setup.py does not support bdist_wheel. The LLM told me it could be a problem in the wheel package. I didn't find what's the problem, but I saw this unrelated tech debt which is we are installing an unnecessary typings package. Hence fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zpcore zpcore zpcore approved these changes

@lsy323 lsy323 Awaiting requested review from lsy323

@ManfeiBai ManfeiBai Awaiting requested review from ManfeiBai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tengyifei @zpcore @qihqi