Add test to ensure scan-based and the standard GRU are interchangeable.#8949
Merged
tengyifei merged 1 commit intopytorch:masterfrom Apr 9, 2025
Merged
Add test to ensure scan-based and the standard GRU are interchangeable.#8949tengyifei merged 1 commit intopytorch:masterfrom
tengyifei merged 1 commit intopytorch:masterfrom
Conversation
Collaborator
Author
|
@tengyifei ensure the scan-based and the standard GRU have the same interface. this is a preparation for replacing the standard with scan-based. please run the tests and review. |
Collaborator
Author
|
the failed tests are not related to the change. maybe due to the flakiness. please run again or ignore the test result. |
tengyifei
approved these changes
Apr 9, 2025
Collaborator
|
Thanks! I think you may ignore GPU failures in the next few days. Still flaky, although we're working on fixing them. This test is covered by TPU and CPU. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a preparation step for replacing the standard GRU implementation with the scan-based implementation. for details: #8860