Skip to content

Fix fp8 test#8909

Merged
lsy323 merged 2 commits intomasterfrom
lsiyuan/fix-fp8-test
Apr 1, 2025
Merged

Fix fp8 test#8909
lsy323 merged 2 commits intomasterfrom
lsiyuan/fix-fp8-test

Conversation

@lsy323
Copy link
Copy Markdown
Collaborator

@lsy323 lsy323 commented Mar 31, 2025

Fixes #8888

Use manual seed to avoid flakiness

@lsy323 lsy323 force-pushed the lsiyuan/fix-fp8-test branch from 74ea3e1 to 984ee57 Compare March 31, 2025 22:18
Copy link
Copy Markdown
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsy323 lsy323 merged commit 985fa18 into master Apr 1, 2025
23 checks passed
@lsy323 lsy323 deleted the lsiyuan/fix-fp8-test branch April 1, 2025 06:08
@zpcore
Copy link
Copy Markdown
Member

zpcore commented Apr 2, 2025

I don't understand why the GPU CI failed since this PR. This is just a seed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_fp8_matmul1 failure

3 participants