Remove dynamic grid#8896
Merged
yaochengji merged 1 commit intopytorch:masterfrom Mar 27, 2025
Merged
Conversation
vanbasten23
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call site of the kernel probably did not check the
cu_q_lens[num_seqs[0]](AKA the actual total num batched q len) is <=max_num_batched_tokens. This could cause hang if we use dynamic grid in kernel.We should consider adding runtime validation before calling the kernel to prevent cases like this.
For now, we just roll back the dynamic grid change to make the integration work.
Tested: