Skip to content

Correct type conversions in OpBuilder and add corresponding test.#8873

Merged
tengyifei merged 1 commit intopytorch:masterfrom
iwknow:type_conversion
Mar 24, 2025
Merged

Correct type conversions in OpBuilder and add corresponding test.#8873
tengyifei merged 1 commit intopytorch:masterfrom
iwknow:type_conversion

Conversation

@iwknow
Copy link
Copy Markdown
Collaborator

@iwknow iwknow commented Mar 22, 2025

This PR contains two changes:

  1. Correct type conversion bug in xla_builder
  2. Add unit test on the type conversion to ensure that correctness of the conversion functions.

This PR fixes #8798 (comment)

@iwknow
Copy link
Copy Markdown
Collaborator Author

iwknow commented Mar 22, 2025

@rpsilva-aws

@tengyifei
Copy link
Copy Markdown
Collaborator

Let's see if CI complains

@tengyifei tengyifei merged commit f2bdecf into pytorch:master Mar 24, 2025
22 checks passed
@iwknow iwknow deleted the type_conversion branch March 30, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xb.Op.scalar maps unsigned int to torch signed int

2 participants