Skip to content

Add build triggers for 2.7-rc1#8828

Merged
zpcore merged 8 commits intomasterfrom
piz/r2.7-trigger
Mar 15, 2025
Merged

Add build triggers for 2.7-rc1#8828
zpcore merged 8 commits intomasterfrom
piz/r2.7-trigger

Conversation

@zpcore
Copy link
Copy Markdown
Member

@zpcore zpcore commented Mar 13, 2025

Add the build trigger to 2.7 branch and fix several build issues:

  1. Missing cuda_deps key for cuda 12.6, 12.8;
  2. Terraform file key field missing syntax issue with cuda nightly build;
  3. Refactor .tf/.tfvars by removing boilerplate code for nightly and release build to make it easier to switch with -rc;
  4. Sync the terraform state to the gcp project setting.

Known issue: BUNDLE_LIBTPU=1 will fail with an unknow address.

@zpcore zpcore marked this pull request as ready for review March 13, 2025 00:16
@zpcore zpcore requested review from ManfeiBai and lsy323 as code owners March 13, 2025 00:16
Comment thread infra/tpu-pytorch-releases/artifacts.auto.tfvars Outdated
@zpcore zpcore force-pushed the piz/r2.7-trigger branch from e5165e4 to f0c0380 Compare March 14, 2025 01:12
@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Mar 14, 2025

I probably find out the issue why CUDA build was not triggered. We have a new option cxx11_abi intorduced, but the field is not added to the CUDA build. This results in the error when call b.cxx11_abi == "1", false.

Apart from that, those .tf configs are quite out dated and not align with the currect GCP config. I have redo the terraform apply to keep everything up to date.

@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Mar 14, 2025

Hi @lsy323 , I have confirmed the syntax correctness with terraform plan and already applied the update to the GCP. Let's see if those wheels can be successfully built or not before merge in. Thanks!

@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Mar 14, 2025

I come to notice that our build will fail if we set BUNDLE_LIBTPU=1. The fail is due to the builder script will look for libtpu from the following address:

https://storage.googleapis.com/libtpu-nightly-releases/wheels/libtpu/libtpu-0.0.11.dev20250303+nightly-py3-none-linux_x86_64.whl

However, the address is not valid anymore. Will fix this issue later.

Copy link
Copy Markdown
Collaborator

@pgmoka pgmoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new paramatized version. LGTM pending approvals from other folks

Copy link
Copy Markdown
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@zpcore zpcore merged commit fed0120 into master Mar 15, 2025
@zpcore zpcore deleted the piz/r2.7-trigger branch March 15, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants