Conversation
f359bce to
9b50d9e
Compare
9b50d9e to
4bb3685
Compare
qihqi
approved these changes
Mar 7, 2025
yaoshiang
approved these changes
Mar 7, 2025
Collaborator
yaoshiang
left a comment
There was a problem hiding this comment.
Approved with some optional nits. Great work on cleaning this up!
pgmoka
reviewed
Mar 10, 2025
pgmoka
reviewed
Mar 10, 2025
4bb3685 to
4a6b5ae
Compare
Collaborator
mikegre-google
left a comment
There was a problem hiding this comment.
Much better descriptions. I have few questions and suggestions..
I was going to document some device ID assignment tricks and then I realized in order to explain that we need to first explain what is a device mesh. The existing documentation is very poor so I'm adding an in-depth guide in this PR. While going over the APIs used I noticed the API documentation and typing also has some problems so I fixed those while I'm here.
4a6b5ae to
bcd4129
Compare
bcd4129 to
69ee526
Compare
Collaborator
|
Looks good. Only one further suggestion... |
Collaborator
|
Thanks for making the change. The reference to JAX guide will be very helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going to document some device ID assignment tricks and then I realized in order to explain that we need to first explain what is a device mesh. The existing documentation is very poor so I'm adding an in-depth guide in this PR.
While going over the APIs used I noticed the API documentation and typing also has some problems so I fixed those while I'm here.