Fix dk/dv autograd error on TPU flash attention#8685
Merged
qihqi merged 1 commit intopytorch:masterfrom Feb 7, 2025
zmelumian972:flash_attention_autograd_dkv_fix
Merged
Fix dk/dv autograd error on TPU flash attention#8685qihqi merged 1 commit intopytorch:masterfrom zmelumian972:flash_attention_autograd_dkv_fix
qihqi merged 1 commit intopytorch:masterfrom
zmelumian972:flash_attention_autograd_dkv_fix
Conversation
…ed on dv flash attention backward function on TPU will only return keys and values gradients if the key gradients is requested by torch.autograd
qihqi
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grads not extracting on flash attention if autograd activated on dv
flash attention backward function on TPU will only return keys and values gradients if the key gradients is requested by torch.autograd