Skip to content

[benchmarks] Fix processing of PyTorch profiler events.#7930

Merged
qihqi merged 1 commit intomasterfrom
ysiraichi/fix-pytorch-profiler-processing
Aug 30, 2024
Merged

[benchmarks] Fix processing of PyTorch profiler events.#7930
qihqi merged 1 commit intomasterfrom
ysiraichi/fix-pytorch-profiler-processing

Conversation

@ysiraichi
Copy link
Copy Markdown
Collaborator

This PR fixes the benchmarking scripts when processing the recorded events from the PyTorch profiler. This modifies the scripts so that running with --profile-cuda-and-cpu and/or --profile-cuda-and-cpu-individual-ops works after pytorch/pytorch#123247.

cc @miladm @zpcore

@ysiraichi ysiraichi requested a review from zpcore August 29, 2024 22:10
Copy link
Copy Markdown
Member

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qihqi qihqi merged commit 1b4b828 into master Aug 30, 2024
@qihqi qihqi deleted the ysiraichi/fix-pytorch-profiler-processing branch August 30, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants