Add Python binding for xla::DotGeneral#7863
Merged
Conversation
55ca18a to
ccb8459
Compare
qihqi
approved these changes
Aug 16, 2024
JackCaoG
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a python binding for
xla::DotGeneral, the motivation is to represent the semantic ofmatmul/einsum(dtype1, dtype2)->dtype3, in whichdtype3can be configurable. Nowtorch.matmulwould always use the inferred output dtype.Function signature is the same as jax.lax.dot_general.
The only limitation is
precisionconfig is not supported, it can be extended easily if needed in the future.Test:
Added unit tests