[Pallas] Support ab for flash_attention#7840
Merged
Conversation
Contributor
|
Thank you @alanwaketan! |
JackCaoG
reviewed
Aug 14, 2024
| @unittest.skipIf(xr.device_type() != 'TPU' or tpu.version() < 3, | ||
| "This test only works on TPUv3+.") | ||
| def test_flash_attention_ab(self): | ||
| jax.config.update("jax_default_matmul_precision", "highest") |
Collaborator
There was a problem hiding this comment.
lol we should really make a context manager that take cares of this in this test.
JackCaoG
approved these changes
Aug 14, 2024
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
Can you rerun the CI? TPUCI was not enabled so the test was not run.
Collaborator
|
actually let me just trigger it... |
Collaborator
Author
|
Thanks, Jack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request adds ab support for flash_attention which is a custom mask for attention weight.
Test Plan:
PJRT_DEVICE=TPU python test/test_pallas.py -v -k test_flash_attention_ab