Attach callback to a Tensor's underlying buffer#7793
Merged
will-cromar merged 9 commits intomasterfrom Aug 5, 2024
Merged
Conversation
ad3a1ee to
c7bc07e
Compare
2b01b06 to
569e2b8
Compare
JackCaoG
reviewed
Aug 2, 2024
JackCaoG
reviewed
Aug 2, 2024
| event = threading.Event() | ||
| c = self.executable() | ||
|
|
||
| def cb(tensor): |
Collaborator
There was a problem hiding this comment.
is it difficult to support the cases where call_back takes more than just the tensor value? call_back might be a general python function that tensor is just one of the inputs.
Collaborator
Author
There was a problem hiding this comment.
You should functools.partial in that case to add other arguments to the callable https://docs.python.org/3/library/functools.html#functools.partial
JackCaoG
reviewed
Aug 2, 2024
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
mostly lgtm, minor nits
JackCaoG
approved these changes
Aug 2, 2024
c32542a to
c46b1c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch_xla.experimental.callback.on_ready_callbackto install callback ((Tensor) -> None) on Tensor, to be called when underlying buffer is readyFuturebecauseTensors are already async results in our case, and returningFutureswould require expanding the API in several places.void()to make Pybind plumbing easiercallbackdoes need to reacquire the GIL from the main threadthread apply all btfromgdbwould be extremely helpful for me to debug.PrepareToExitnow waits for pending runtime operations to complete. Otherwise, we start destroying the runtime client before operations are done. If the main thread is waiting for a callback to complete, a deadlock occurs.