Skip to content

Use launch() for all multiprocessing#7764

Merged
zpcore merged 4 commits intomasterfrom
piz/use-launch
Jul 31, 2024
Merged

Use launch() for all multiprocessing#7764
zpcore merged 4 commits intomasterfrom
piz/use-launch

Conversation

@zpcore
Copy link
Copy Markdown
Member

@zpcore zpcore commented Jul 29, 2024

Use torch_xla.launch() instead of xmp.spawn() in our codebase.

Note that xmp.spawn() still works.

@zpcore zpcore added the tpuci label Jul 29, 2024
@zpcore zpcore force-pushed the piz/use-launch branch 3 times, most recently from ed0e7a8 to d9a98cd Compare July 29, 2024 21:41
@zpcore zpcore marked this pull request as ready for review July 30, 2024 01:14
@zpcore zpcore requested a review from will-cromar July 30, 2024 01:14
@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Jul 30, 2024

The CI failure is due to upstream (pytorch/pytorch#131275) as @JackCaoG mentioned.

@zpcore zpcore requested a review from JackCaoG July 30, 2024 01:16
Comment thread test/test_train_mp_imagenet_amp.py Outdated
Copy link
Copy Markdown
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@zpcore zpcore merged commit 6c18d50 into master Jul 31, 2024
@zpcore zpcore deleted the piz/use-launch branch July 31, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants