Skip to content

update debug_single_process to false#7695

Merged
zpcore merged 2 commits intomasterfrom
piz/fix_mp
Jul 17, 2024
Merged

update debug_single_process to false#7695
zpcore merged 2 commits intomasterfrom
piz/fix_mp

Conversation

@zpcore
Copy link
Copy Markdown
Member

@zpcore zpcore commented Jul 16, 2024

No description provided.

@zpcore zpcore requested review from will-cromar and wonjoo-wj July 16, 2024 20:44
@zpcore zpcore marked this pull request as ready for review July 16, 2024 21:57
Copy link
Copy Markdown
Collaborator

@will-cromar will-cromar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread test/test_train_mp_imagenet.py Outdated
@zpcore zpcore merged commit 44f88a9 into master Jul 17, 2024
@zpcore zpcore deleted the piz/fix_mp branch July 17, 2024 04:35
@miladm
Copy link
Copy Markdown
Collaborator

miladm commented Jul 22, 2024

qq: is there a plan to migrate all such API calls? (e.g. https://github.com/pytorch/xla/blob/master/test/test_train_mp_mnist.py#L220) @zpcore

@miladm miladm added the usability Bugs/features related to improving the usability of PyTorch/XLA label Jul 22, 2024
@zpcore
Copy link
Copy Markdown
Member Author

zpcore commented Jul 22, 2024

qq: is there a plan to migrate all such API calls? (e.g. https://github.com/pytorch/xla/blob/master/test/test_train_mp_mnist.py#L220) @zpcore

Yes, I will make a follow up PR to apply torch_xla.launch() to all tests and update the doc. @will-cromar and @JackCaoG to see if you have any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

usability Bugs/features related to improving the usability of PyTorch/XLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants