Add 1-layer gradient accumulation test to check aliasing#7692
Merged
Add 1-layer gradient accumulation test to check aliasing#7692
Conversation
Collaborator
|
Thanks Jeff, I think it is better to fix the issue first and then merge this pr. |
JackCaoG
reviewed
Aug 1, 2024
Comment on lines
+127
to
+132
| assert ( | ||
| graph_count == 2 | ||
| ), f"Expect 2 graphs for gradient accumulation test, got {graph_count}" | ||
| assert ( | ||
| alias_count == 1.0 | ||
| ), f"Expect 1 input-output alias pair for gradient accumulation, got {alias_count}" |
Collaborator
There was a problem hiding this comment.
nit can we use self.assertEqual? You can fix that in a follow up pr.
JackCaoG
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 1-layer gradient accumulation test to check aliasing for #7174.
Currently test is skipped. Once #7174 is fixed we can unskip.
If unskip now, you will get: