support gmm as a custom op for dynamo#7672
Merged
Conversation
qihqi
approved these changes
Jul 12, 2024
alanwaketan
reviewed
Jul 12, 2024
| import torch_xla | ||
| import torch_xla.core.xla_model as xm | ||
| import torch_xla.distributed.spmd as xs | ||
| import torch_xla.debug.metrics as met |
Collaborator
There was a problem hiding this comment.
Do you add this in accident?
Collaborator
Author
There was a problem hiding this comment.
lol forgot to delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch actually will not run functionization inside a custom op. This means we should avoid using the in place ops for all of the custom op implementation. For this op I made
gmmfunctional.From @bdhirsh