Conversation
a84f2b2 to
ba4603d
Compare
ysiraichi
reviewed
Jun 17, 2024
Collaborator
ysiraichi
left a comment
There was a problem hiding this comment.
Nice PR. I have pointed out a few places where type hints are still missing.
One additional comment: I think it would be better to update the PR title, so that it represents what you are doing here. It doesn't really fixes any document, does it?
vanbasten23
reviewed
Jun 18, 2024
vanbasten23
reviewed
Jun 18, 2024
vanbasten23
reviewed
Jun 18, 2024
vanbasten23
reviewed
Jun 18, 2024
vanbasten23
reviewed
Jun 18, 2024
Collaborator
|
Mostly LGTM with minor comments. Thanks! |
ysiraichi
reviewed
Jun 18, 2024
Collaborator
|
Are we also going to start using |
Member
Author
@will-cromar and @JackCaoG to see if we have such plan. |
vanbasten23
reviewed
Jun 20, 2024
|
|
||
| def _is_available(self, experiment_config): | ||
| def _is_available(self, | ||
| experiment_config: List[Dict[str, |
Collaborator
There was a problem hiding this comment.
lol, our benchmark script is complicated
vanbasten23
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type annotations for
benchmarks/.Also relocated some functions due to circular import.