Allow user to configure distributed runtime service.#7204
Merged
vanbasten23 merged 1 commit intomasterfrom Jun 6, 2024
Merged
Conversation
jonb377
approved these changes
Jun 6, 2024
will-cromar
approved these changes
Jun 6, 2024
Collaborator
Author
How do you know the compilation has finished?
Yeah, it's also my guess on why it fails. I'd need this PR to verify the hypothesis. |
Collaborator
|
Collaborator
Author
|
Thanks Jon and Will for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GKE, the multi-host GPU training always fails after 5 min into the training, without a clear error message (see the log on the 2 hosts: https://gist.github.com/vanbasten23/bdced1d993fa604025d318e9d68a2f6b https://gist.github.com/vanbasten23/cc4096a869e0278eb414642dd7662166). It fails on larger model such as LLM but succeeds on smaller model such as resnet.
By following JAX's example, we allow user to configure max_missing_heartbeats, heartbeat_interval, distributed_shutdown_timeout. I suspect the failure is due to one of the configuration's default value being too small.