Conversation
JackCaoG
reviewed
May 8, 2024
| causal=False, | ||
| q_segment_ids=None, | ||
| kv_segment_ids=None, | ||
| sm_scale=1.0, |
Collaborator
There was a problem hiding this comment.
it this a training only thing so we don't need to add it for the dynamo?
Collaborator
Author
There was a problem hiding this comment.
We can support it in dynamo too. I will have a follow up to add some missing dynamo parameters.
JackCaoG
approved these changes
May 8, 2024
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
approve to unblock, have 1 comment that can be address in a follow up pr if needed.
Collaborator
Author
|
Thanks Jack! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request is to support the scaling factor for flash attention's attention weight.
Test Plan:
PJRT_DEVICE=TPU python test/test_pallas.py