Support export custom op to stablehlo custom call#7017
Merged
Conversation
added 2 commits
May 2, 2024 05:04
qihqi
reviewed
May 2, 2024
qihqi
approved these changes
May 2, 2024
|
Hi @lsy323, thanks for the amazing work! We are investigating issue #8385 and found that Do you know if there is a way to restore aliasing information here? If not, do you recall what the limitation is that caused the asliasing information to be dropped here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #6979
Support export custom op to stablehlo custom call, there are 2 user journeys
StableHLOExportOptionsExample output
stablehlo_custom_callAPI in the XLA dispatch impl of the custom op, with more control on the generated custom callexample ouptut
Test: Added unit tests to cover multiple inputs/outputs, and 2 user jouneys.
Future work:
stablehlo_custom_callas a torch op, currently the op schema failed with parameter type ofScalarType[].tpu_custom_callcode path andcustom_callcode path. Currently there are duplicated code in 2 paths.tpu_custom_callshould be a special use case of custom_call. Need to extend custom_call to supportxla::CustomCallWithLayoutcc @alanwaketancc @GleasonK