Skip to content

[benchmarks] Use Torchbench YAML configuration data.#6881

Merged
ysiraichi merged 3 commits intomasterfrom
ysiraichi/use-torchbench-yaml-data
Apr 4, 2024
Merged

[benchmarks] Use Torchbench YAML configuration data.#6881
ysiraichi merged 3 commits intomasterfrom
ysiraichi/use-torchbench-yaml-data

Conversation

@ysiraichi
Copy link
Copy Markdown
Collaborator

This PR makes the benchmarking scripts to start using the configuration YAML file exposed by PyTorch. Previously, we were using it only for checking models that should be skipped. From this PR onwards, we are using the configuration file for other things, such as:

  • Deciding what should be the data-type
  • Checking whether a model is a Detectron2 model

cc @miladm

@zpcore
Copy link
Copy Markdown
Member

zpcore commented Apr 3, 2024

Thanks! Logics look good to me. Can you move function config_data() into the front of the file?

Copy link
Copy Markdown
Collaborator

@vanbasten23 vanbasten23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ysiraichi ysiraichi merged commit 7520c04 into master Apr 4, 2024
@zpcore zpcore deleted the ysiraichi/use-torchbench-yaml-data branch April 4, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants