[Fori_loop|While_loop] Fori loop wrapped from while_loop#6850
Merged
[Fori_loop|While_loop] Fori loop wrapped from while_loop#6850
Conversation
qihqi
reviewed
Mar 29, 2024
6439a0a to
15fdd9a
Compare
qihqi
approved these changes
Apr 4, 2024
yeounoh
reviewed
Apr 5, 2024
yeounoh
reviewed
Apr 5, 2024
yeounoh
reviewed
Apr 5, 2024
yeounoh
reviewed
Apr 5, 2024
yeounoh
reviewed
Apr 5, 2024
yeounoh
reviewed
Apr 5, 2024
yeounoh
reviewed
Apr 5, 2024
| def _xla_while_loop(cond_fn, body_fn, *carried_inputs, additional_inputs): | ||
| # untuple carried_inputs from while_loop | ||
| carried_inputs = carried_inputs[0] | ||
| # fake carried_inputs to split formal code |
Contributor
There was a problem hiding this comment.
@JackCaoG could you help me understand this part? why we need this.
Collaborator
Author
There was a problem hiding this comment.
more context: this part create fake tensor from input tensors, so that fake tensor would not include formal IR like input tensors, and then we use clean fake tensor to create body_xlacomputation/cond_xlacomputation
yeounoh
suggested changes
Apr 5, 2024
Contributor
yeounoh
left a comment
There was a problem hiding this comment.
Looks good, left some comments for minor changes.
4e0dcaa to
dd8ec42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.