Merged
Conversation
JackCaoG
approved these changes
Mar 27, 2024
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
How many more pallas related pr you need to backport? Ideally we should not backport feature to the 2.3 branch anymore.
Collaborator
Author
|
Most of them are landed last week. Just they all have dependence. So I have to back port them one by one... |
Collaborator
Author
|
The flash attention forward related feature are done. I will only backport the fixes from now on. For backward and distributed, I won't backport them to 2.3. |
lsy323
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request introduces a FlashAttention wrapper that aims to:
Test Plan:
PJRT_DEVICE=TPU python test/test_pallas.py -v -k test_flash_attention_wrapper