Add experimental MLIR debuginfo writer API#6799
Merged
Conversation
Collaborator
Author
|
@qihqi I don't know what |
|
Looking forward to testing this change! Thank you! |
lsy323
approved these changes
Mar 25, 2024
Collaborator
lsy323
left a comment
There was a problem hiding this comment.
Left some nit and questions. Overall LGTM, thanks @chunnienc
Collaborator
|
@chunnienc Could you rebase to torch_xla HEAD? Seems there was a PyTorch PR reverted causing the torch_xla HEAD broken earlier today. The corresponding PR (#6819) is reverted in PyTorch/XLA as well. So rebase to HEAD should resolve the CI failure. |
Collaborator
|
@chunnienc Looks like your local master is not updated? Saw some unexpected changes in the diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental API to associate a string with a XLA tensor, which will eventually be propagated to the MLIR NameLoc in the lowerings.
Internal reference: https://b.corp.google.com/issues/330605426