Change ATEN generator argument type to const std::optional<Generator>᨞
Merged
alanwaketan merged 3 commits intomasterfrom Mar 7, 2024
Merged
Change ATEN generator argument type to const std::optional<Generator>᨞alanwaketan merged 3 commits intomasterfrom
alanwaketan merged 3 commits intomasterfrom
Conversation
cyyever
approved these changes
Mar 7, 2024
Collaborator
|
@alanwaketan The upstream PR has been merged. |
Collaborator
Author
|
@yeounoh Not sure why kokoro is broken while others are passing. I guess I'm just going to land this change directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
To adopt the changes in pytorch/pytorch#120076
To be noted, the original author is @cyyever and this is copied from #6595
Test Plan:
CI