Closed
Conversation
wonjoo-wj
reviewed
Aug 12, 2023
yeounoh
reviewed
Aug 12, 2023
yeounoh
reviewed
Aug 12, 2023
| coll.device = device; | ||
| coll.unlocker = DeviceLockerArena::Get()->LockDevices({device}); | ||
| // init this before the lock to save some time. | ||
| // std::vector<torch::lazy::BackendDataPtr> arguments(graph_inputs.size()); |
Contributor
There was a problem hiding this comment.
nit. Remove this commented code?
yeounoh
reviewed
Aug 12, 2023
yeounoh
reviewed
Aug 12, 2023
| // GetXlaData must be called within a lock region, otherwise it might | ||
| // extract the placeholder inserted by previous execution. | ||
| TORCH_LAZY_TIMED("RunCachedGraphInputData"); | ||
| // size_t per_thread_work = 200; |
Contributor
There was a problem hiding this comment.
I see a bunch of commented lines here -- maybe we should clean them before mering?
yeounoh
reviewed
Aug 12, 2023
yeounoh
reviewed
Aug 12, 2023
yeounoh
reviewed
Aug 12, 2023
Collaborator
Author
|
@yeounoh This pr has been too big, let me split it up and open smaller ones. |
This was referenced Aug 14, 2023
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With SPMD one process needs to handle all device within a single host, this pr tries to parallelize some of the per-device operation.