Companion PR for pytorch/pytorch#106272#5376
Closed
nkaretnikov wants to merge 1 commit intomasterfrom
Closed
Conversation
Collaborator
Author
|
Added meta for median in pytorch/pytorch#106272, which affected the counters. |
6ea0ac1 to
a7b935a
Compare
Collaborator
Author
|
Forgot to rebase on origin/master, fixed now. |
JackCaoG
requested changes
Jul 31, 2023
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
oh so the actual fix should be use a different op that pytorch/xla does not support. The purpose of this test is to test the fallback. @wonjoolee95 can you help on finding a new op that will fallback?
Collaborator
Author
|
@JackCaoG @wonjoolee95 How about |
Collaborator
|
yea any op that will fallback in pytorch/xla will do I believe |
Collaborator
|
Thanks @nkaretnikov, |
Collaborator
Author
|
@wonjoolee95 sounds good, closing this one, then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.