Skip to content

Lower count_nonzero#5137

Merged
JackCaoG merged 19 commits intomasterfrom
xiowei/lowerCount_nonzero
Jun 12, 2023
Merged

Lower count_nonzero#5137
JackCaoG merged 19 commits intomasterfrom
xiowei/lowerCount_nonzero

Conversation

@vanbasten23
Copy link
Copy Markdown
Collaborator

@vanbasten23 vanbasten23 commented Jun 7, 2023 •
edited
Loading

This pr is to fix issue #5031 by lowering count_nonzero.

@vanbasten23 vanbasten23 marked this pull request as draft June 7, 2023 18:15
@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Jun 7, 2023

can you resolve the merge conflict?

@vanbasten23 vanbasten23 force-pushed the xiowei/lowerCount_nonzero branch from 6ef38cd to 8421270 Compare June 7, 2023 19:28
@vanbasten23 vanbasten23 changed the title Lower count_nonzero [DO NOT REVIEW] Lower count_nonzero Jun 7, 2023
@vanbasten23 vanbasten23 changed the title [DO NOT REVIEW] Lower count_nonzero Lower count_nonzero Jun 7, 2023
@vanbasten23 vanbasten23 marked this pull request as ready for review June 7, 2023 20:45
cowanmeg
cowanmeg approved these changes Jun 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cowanmeg cowanmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

JackCaoG
JackCaoG reviewed Jun 8, 2023
View reviewed changes
Comment thread test/cpp/test_aten_xla_tensor_1.cpp Outdated
JackCaoG
JackCaoG reviewed Jun 8, 2023
View reviewed changes
Comment thread test/cpp/test_aten_xla_tensor_1.cpp Outdated
JackCaoG
JackCaoG reviewed Jun 8, 2023
View reviewed changes
Comment thread torch_xla/csrc/ops/count_nonzero.cpp Outdated
JackCaoG
JackCaoG reviewed Jun 8, 2023
View reviewed changes
Comment thread torch_xla/csrc/ops/count_nonzero.cpp Outdated
JackCaoG
JackCaoG reviewed Jun 8, 2023
View reviewed changes
Comment thread torch_xla/csrc/xla_lower_util.cpp
@vanbasten23 vanbasten23 requested a review from JackCaoG June 9, 2023 00:45
JackCaoG
JackCaoG reviewed Jun 9, 2023
View reviewed changes
Comment thread torch_xla/csrc/ops/count_nonzero.cpp Outdated
@vanbasten23 vanbasten23 requested a review from JackCaoG June 9, 2023 23:16
JackCaoG
JackCaoG approved these changes Jun 12, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vanbasten23 !

@JackCaoG JackCaoG merged commit 4da677c into master Jun 12, 2023
@JackCaoG JackCaoG added the lowering ATen Operation lowering label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

@wonjoo-wj wonjoo-wj Awaiting requested review from wonjoo-wj

+1 more reviewer

@cowanmeg cowanmeg cowanmeg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lowering ATen Operation lowering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vanbasten23 @JackCaoG @cowanmeg