[Distributed] Adopts traceable all_reduce#4915
Merged
alanwaketan merged 4 commits intomasterfrom Apr 21, 2023
Merged
Conversation
0c6f3f0 to
867b437
Compare
wconstab
reviewed
Apr 20, 2023
wconstab
reviewed
Apr 20, 2023
| // pin layout. | ||
| auto result = tensor_methods::all_reduce(self_tensor, GetReduceType(reduceOp), | ||
| /*scale*/ 1.0, | ||
| /*groups*/ {}, /*pin_layout*/ true); |
Collaborator
There was a problem hiding this comment.
do you need some way to translate between our tag rank stride format and xla's groups format?
Collaborator
Author
There was a problem hiding this comment.
Yea, will follow up with that later.
JackCaoG
approved these changes
Apr 21, 2023
Collaborator
Author
|
Thanks Jack for approving the change. |
42c769f to
ce26d1a
Compare
867b437 to
2a2ae53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request adopts the traceable all_reduce as mentioned in pytorch/pytorch#93173.
Test Plan:
PJRT_DEVICE=TPU python test/test_mp_replication.py