Minor fix: ZeRO-1 grad clipping#4796
Merged
alanwaketan merged 2 commits intopytorch:masterfrom May 2, 2023
Merged
Conversation
Collaborator
Author
|
@JackCaoG could you help add some reviewers? |
Collaborator
|
@hgt312 sorry I was out for last few weeks, let me try to take a look. |
Collaborator
|
Do we have a test case already? |
Collaborator
Author
yes, in #4648 |
Collaborator
Thanks. Can you mention that in the description? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementation and test in previous PR #4648
reduce local norm across shards