Run cached graph api should grab device lock first#4195
Merged
Conversation
alanwaketan
approved these changes
Nov 12, 2022
| torch::lazy::ComputationPtr computation, | ||
| c10::ArrayRef<torch::lazy::BackendDataPtr> arguments, | ||
| const torch::lazy::BackendDevice& device) { | ||
| std::vector<xla::util::ExceptionCleanup> unlocker; |
Collaborator
There was a problem hiding this comment.
One more thing to count on LTC migration. haha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to grab the device lock before execute the computation in
_run_cached_graph. This is to prevent more than 1 graph being executed in the same time.Current implementation we can only grab lock within
tensor.cpphence this change.FYI @shunting314 @wconstab