Update div rounding_mode argument to optional<string>#2859
Merged
JackCaoG merged 5 commits intopytorch:masterfrom Apr 5, 2021
Merged
Update div rounding_mode argument to optional<string>#2859JackCaoG merged 5 commits intopytorch:masterfrom
JackCaoG merged 5 commits intopytorch:masterfrom
Conversation
JackCaoG
requested changes
Apr 2, 2021
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
Thanks @peterbell10 ! Mostly LGTM, one nit.
Collaborator
|
Can you also fix the c++ format by https://github.com/pytorch/xla/blob/master/CONTRIBUTING.md#c-style-guide |
78fd9eb to
e4de8fd
Compare
Collaborator
|
Could you add a This will point the pytorch to a specific pr when building with circleCI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements pytorch/pytorch#51988.
rounding_mode="true"is nowrounding_mode=None.