Hi @mateuszlewko ,
I wonder if the new wheel build process (with ansible) can disable cxx_abi when it builds a torch_xla wheel for a release branch (such as r2.0). We recently build a torch_xla wheel (on pt/xla branch r2.0, cuda 11.8, python=3.10). From the log, it seems it still enables cxx_abi (I see -D_GLIBCXX_USE_CXX11_ABI=1 in the log above, which make me think it enables cxx_abi. Please correct me if I'm wrong.). Building an official torch_xla with cxx_abi enabled causes torch_xla wheel to be incompatible with torch's wheel.
What we used to do in the release branch, is to first apply a torch patch (as in this pr), then disable the cxx_abi (as in this pr). So my question is
- With ansible, does the wheel have cxx abi enabled?
- If so for above question, with ansible, is it possible to apply the torch patch file first and then set the flag to be false?
Thanks.
cc: @JackCaoG @miladm
Hi @mateuszlewko ,
I wonder if the new wheel build process (with ansible) can disable cxx_abi when it builds a torch_xla wheel for a release branch (such as r2.0). We recently build a torch_xla wheel (on pt/xla branch r2.0, cuda 11.8, python=3.10). From the log, it seems it still enables cxx_abi (I see
-D_GLIBCXX_USE_CXX11_ABI=1in the log above, which make me think it enables cxx_abi. Please correct me if I'm wrong.). Building an official torch_xla with cxx_abi enabled causes torch_xla wheel to be incompatible with torch's wheel.What we used to do in the release branch, is to first apply a torch patch (as in this pr), then disable the cxx_abi (as in this pr). So my question is
Thanks.
cc: @JackCaoG @miladm