add prototype implementation for MNIST and CIFAR#4414
add prototype implementation for MNIST and CIFAR#4414pmeier merged 4 commits intopytorch:prototypefrom
Conversation
|
I know it's extremely early to comment but I'm very interested in the So couple of questions:
|
I think so.
For me, yes. I'm going for the same tree as the default
For now this PR will not be merged into |
|
Given that this is landing in the Also, one thing which is currently missing in the current version is the ability to query the number of classes (or class names) from the dataset builder. This is something we need to get in our new design in a consistent way |
This looks consistent with the way torchaudio is doing. (note that Torchtext's AFAIK only the top-level name One reminder is to make sure that it's user's responsibility to explicitly import prototype module. meaning, do not import
Speaking this for general cases, it depends. Torchaudio had C++ code in prototype, but the code itself lived in
It will be ideal to have a permanent mechanism in I once thought of working on it, but I did not have time, and meanwhile prototype features in torchaudio changed a lot so I did not do. It was not too bad to manually remove them in release branch. |
Yeah, |
|
Also one recommendation is to have the documentation ready for prototype feature. That really eases the communication. |
|
The intention to not have this in |
No description provided.