[WIP] Allow autocast for 1.6 (#2384)#2442
Merged
fmassa merged 1 commit intopytorch:release/0.7from Jul 9, 2020
Merged
Conversation
* Fixes Xiao's repro * Ports nms to use full dispatcher * Move HIPGuard to nms_cuda * clang-format * run models in test_models.py on GPU if available * Francisco's comment, also disable cuda model tests to see if CPU alone still passes * cuda tests now pass locally, although still not comparing to saved numerics * add note for thing to ask francisco * Allow cuda and cpu tests to share a data file * ignore suffix if unneeded * Skip autocast numerics checks for a few models * Add roi_align test Co-authored-by: Michael Carilli <mcarilli@nvidia.com>
Codecov Report
@@ Coverage Diff @@
## release/0.7 #2442 +/- ##
============================================
Coverage 68.58% 68.58%
============================================
Files 93 93
Lines 7608 7608
Branches 1159 1159
============================================
Hits 5218 5218
Misses 2064 2064
Partials 326 326
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Xiao's repro
Ports nms to use full dispatcher
Move HIPGuard to nms_cuda
clang-format
run models in test_models.py on GPU if available
Francisco's comment, also disable cuda model tests to see if CPU alone still passes
cuda tests now pass locally, although still not comparing to saved numerics
add note for thing to ask francisco
Allow cuda and cpu tests to share a data file
ignore suffix if unneeded
Skip autocast numerics checks for a few models
Add roi_align test
Co-authored-by: Michael Carilli mcarilli@nvidia.com