Support Exporting GeneralizedRCNNTransform to ONNX#1325
Merged
fmassa merged 7 commits intopytorch:masterfrom Sep 17, 2019
Merged
Support Exporting GeneralizedRCNNTransform to ONNX#1325fmassa merged 7 commits intopytorch:masterfrom
fmassa merged 7 commits intopytorch:masterfrom
Conversation
fmassa
requested changes
Sep 11, 2019
Member
fmassa
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I have some inline comments, let me know what you think
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
- Coverage 65.77% 65.58% -0.19%
==========================================
Files 75 75
Lines 5791 5818 +27
Branches 887 892 +5
==========================================
+ Hits 3809 3816 +7
- Misses 1716 1735 +19
- Partials 266 267 +1
Continue to review full report at Codecov.
|
This was referenced Sep 12, 2019
fmassa
requested changes
Sep 12, 2019
Member
fmassa
left a comment
There was a problem hiding this comment.
This is almost good to merge, just one minor comment.
Also, I have a question in the comments, which I'd like to get your thoughts on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications to GeneralizedRCNNTransform to export the image preprocessing (batch_imgs).
The dded test is disabled until Resize is implemented for opset 11 in ONNX Runtime (for now interpolate with bilinear mode is not well supported in PyTorch master, so the test will fail. I tested locally the changes in this PR by changing 'bilinear' mode to 'nearest' (without align_corners) and matching numbers with ORT and analysing the exported model).