This repository was archived by the owner on Aug 1, 2025. It is now read-only.
extend __torch_function__ support to call_method#181
Merged
Conversation
vkuzo
commented
Apr 26, 2022
d07473b to
28f92b3
Compare
jansel
suggested changes
Apr 26, 2022
Contributor
jansel
left a comment
There was a problem hiding this comment.
Overall looks good. A few minor comments.
Summary: In #167 we added `__torch_function__` support for tracing through `call_function`. This PR extends the support to also work on `call_method`. Note: the LOC is high because some code was refactored to be reusable. Note: implementing correct rewrapping logic for methods is saved for a future PR, hope that's OK. Test plan: ``` pytest -vsk test_simple_torch_function ```
jansel
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In #167 we added
__torch_function__support for tracing through
call_function.This PR extends the support to also work on
call_method.Note: the LOC is high because some code was refactored to be reusable.
Note: implementing correct rewrapping logic for methods is saved for a
future PR, hope that's OK.
Test plan: