Fix stale Dr. CI comment after retrying jobs#851
Merged
huydhn merged 2 commits intopytorch:mainfrom Oct 6, 2022
Merged
Conversation
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
malfet
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, I realize that Dr. CI doesn't take the results of retrying jobs into account and this leads to a discrepancy between Dr. CI comment, HUD, and GitHub signal box. This is an example pytorch/pytorch#85313 where Dr. CI reports a failing job while none is showed in https://hud.pytorch.org/pr/85313 or GitHub signal box. The failed jobs was retried successfully.
Also cleaning up the
recent_pr_workflows_queryquery a bit and addingrun_attemptfield.