Add 'advisor' to autorevert_events_v2 action enum#7878
Merged
izaitsevfb merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
The autorevert AI advisor lambda writes action='advisor' to ClickHouse, but the Enum8 column only accepted 'none', 'restart', 'revert'. This caused all advisor rows to be silently stored as 'none', breaking the dedup query (prior_advisor_exists) which filters on action='advisor'. The result was unlimited re-dispatches of the advisor workflow for the same (commit, signal) pair every ~5 minutes. Authored with Claude.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
jeanschmidt
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'advisor' = 3to theactionEnum8 column inmisc.autorevert_events_v2The autorevert AI advisor lambda (pytorch/pytorch PR #177404) writes
action='advisor'when logging dispatch events to ClickHouse. However, the table's Enum8 only acceptednone,restart,revert— causing ClickHouse to silently store advisor rows asaction='none'.This broke
prior_advisor_exists()andadvisor_count_for_commit()which queryWHERE action = 'advisor'— they always returned false/0, so the lambda re-dispatched the advisor workflow for the same (commit, signal) every ~5 minutes indefinitely.Already applied live:
Test plan
action='advisor'prior_advisor_exists()returns true after first dispatch, preventing duplicates